PSR-2 / Composer Compliance

[Cyrus Collier]

The file lib/init.php doesn’t follow PSR-1/2 side effects guidelines (http://www.php-fig.org/psr/psr-1/#2-3-side-effects). Ordinarily it wouldn’t be a big deal for a plugin initialization file but because this file is a composer autoloaded file, it could cause future issues with autoloading the class, and I’m guessing it’s not following Composer autoloading best practices to autoload a class that also instantiates an object.

Recommendations: Either remove lib/init.php from the autoloader and require it directly from the main plugin file, or move the instantiation code to the main plugin file to be PSR-1/2 compliant.

[Khaled]

Hi Cyrus,

Your reported PSR-2 compliant issue has been fixed by current RC release.

Thanks.

[Author]

Posts